Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit Japanese description #3167

Merged
merged 2 commits into from
Dec 6, 2023
Merged

Edit Japanese description #3167

merged 2 commits into from
Dec 6, 2023

Conversation

KaitoMuraoka
Copy link
Contributor

  • Have you followed the contributing guidelines?
  • Have you explained what your changes do, and why they add value to the Guides?

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

Explanation

I've added punctuation marks to the description for the following two reasons:

  1. Periods in English can be recognized as the Japanese punctuation mark "。".
  2. It's considered good practice to end sentences with punctuation marks. This is also a rule in textLint.
日本語

説明

以下2つの理由で description に句読点を追加しました。

  1. 英語でのピリオドは、日本語では句読点「。」として認識することができます。
  2. 文の最後は句読点で終了するのが良いとされています。これは textLint でもルールが存在します。

@KaitoMuraoka KaitoMuraoka marked this pull request as ready for review November 7, 2023 01:23
@KaitoMuraoka KaitoMuraoka requested a review from a team as a code owner November 7, 2023 01:23
tomthorogood
tomthorogood approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@tomthorogood tomthorogood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tomthorogood tomthorogood added this pull request to the merge queue Nov 20, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 20, 2023
@ahpook ahpook added this pull request to the merge queue Dec 6, 2023
Merged via the queue into github:main with commit b9b78a6 Dec 6, 2023
3 checks passed
@KaitoMuraoka KaitoMuraoka deleted the fix/correct-punctuation branch December 7, 2023 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomthorogood tomthorogood tomthorogood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KaitoMuraoka @tomthorogood @ahpook